Cabal file improvements #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cabal 3.8 allows multiple subdirs to be pulled from the some repository.
This shares common build options across various targets, to make it easier to be consistent (e.g., this caught a number of warnings because `-Wall` hadn’t been applied to all targets. It also helps highlight the difference between otherwise similar targets. Unfortunately, you can’t share stanzas between cabal files, so the `defaults` stanza is duplicated in every package. We’ll need something like [hpack-dhall](https://github.com/cabalism/hpack-dhall) to fix that.
This has been around since 2.0, and adopting it is long overdue. This mostly doesn’t change bounds, but bumps the lower bound on `base` to eliminate some that we don’t actually support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes advantage of some newer features (e.g.,
source-repository-packagecan now list multiple subdirs) and makes some other improvements.There is unfortunately still a lot of duplication. Cabal 3.8 supports multiple public libraries in a package, which can help a bit, but
cabal2nixdoesn’t yet handle that (NixOS/cabal2nix#448). Alternatively, something like hpack-dhall would help a lot, but in general, I’ve tried to avoid any preprocessing in order to get Cabal to build things outside of Nix.It’s probably easiest to review this PR commit-by-commit.