fix: set initial ordering to relevance in the frontend component
#766
Conversation
asuworks
changed the title
relevance in the frontend componentrelevance in the frontend component
asuworks
changed the title
relevance in the frontend componentrelevance in the frontend component
| @@ -141,7 +141,7 @@ const initializeFilterValues = () => { | |||
| values.endDate = urlParams.get("publishedBefore") | |||
| ? new Date(urlParams.get("publishedBefore")!) | |||
| : null; | |||
| values.ordering = urlParams.get("ordering") || "-first_published_at"; | |||
| values.ordering = urlParams.get("ordering") || "relevance"; | |||
There was a problem hiding this comment.
Can you explain what behavior this is attempting to fix? The initial sort order should be newest to oldest as "relevance" doesn't make sense on initial load; won't this set the initial sort order to "relevance" when the ordering query param isn't explicitly set?
There was a problem hiding this comment.
If the user sets the ordering explicitely, the ordering will be available through urlParams.get("ordering"). If not, the default ordering during searching (seqrch query is not empty) is "relevance".
But I guess, you also have a point, namely: when there is no search query, just filtering by programming languages. In which case it should be something like:
values.ordering = urlParams.get("ordering") || (urlParams.get("query") ? "relevance" : "-first_published_at");
…to -first_publiched_at
change to "clear search" and include for queries as well we should not list a sort by relevance when there is no search query
|
Here is a quick fix to remove |
|
looks good to me, go ahead and submit a new PR for it and we'll get it merged and deployed |
No description provided.