Skip to content

Commit

Permalink
fix: remove the option to create non-existent tags in the tag filter …
Browse files Browse the repository at this point in the history
…on the sidebars: Codebase, Event, Jobs, Profile
  • Loading branch information
asuworks committed Oct 24, 2024
1 parent d677094 commit 6b7897a
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 4 deletions.
1 change: 1 addition & 0 deletions frontend/src/components/CodebaseListSidebar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
label="Tags"
type="Codebase"
placeholder="Language, framework, etc."
:taggable="false"
/>
</form>
</template>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/EventListSidebar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
>
<template #form>
<form @submit="handleSubmit">
<TaggerField class="mb-3" name="tags" label="Keywords" type="Event" />
<TaggerField class="mb-3" name="tags" label="Keywords" type="Event" :taggable="false" />
<DatepickerField
class="mb-3"
name="submissionDeadlineAfter"
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/JobListSidebar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
>
<template #form>
<form @submit="handleSubmit">
<TaggerField class="mb-3" name="tags" label="Keywords" type="Job" />
<TaggerField class="mb-3" name="tags" label="Keywords" type="Job" :taggable="false" />
<DatepickerField class="mb-3" name="initialPostingAfter" label="Posted after" />
<DatepickerField name="applicationDeadlineAfter" label="Application deadline after" />
</form>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/ProfileListSidebar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
>
<template #form>
<form @submit="handleSubmit">
<TaggerField name="tags" label="Keywords" type="Profile" />
<TaggerField name="tags" label="Keywords" type="Profile" :taggable="false" />
<!-- consider adding full member/peer reviewer filter -->
</form>
</template>
Expand Down
4 changes: 3 additions & 1 deletion frontend/src/components/form/TaggerField.vue
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
:clear-on-select="false"
:close-on-select="false"
:options-limit="50"
:taggable="true"
:taggable="taggable"
:limit="20"
@tag="addTag"
@search-change="fetchMatchingTags"
Expand Down Expand Up @@ -66,11 +66,13 @@ export interface TaggerFieldProps {
help?: string;
placeholder?: string;
required?: boolean;
taggable?: boolean;
type?: TagType;
}
const props = withDefaults(defineProps<TaggerFieldProps>(), {
type: "",
taggable: true,
placeholder: "Type to add tags",
});
Expand Down

0 comments on commit 6b7897a

Please sign in to comment.