Skip to content

Commit

Permalink
deps: remove markupsafe pin (#768)
Browse files Browse the repository at this point in the history
* deps: remove markupsafe v2 pin

resolves comses/planning#277

* test(e2e): give release editor some time to initialize

rarely, the test would hang up on a (inconsequential) TypeError on the
client if it tried to do stuff before the release editor store was initialized
  • Loading branch information
sgfost authored Oct 18, 2024
1 parent b8bc243 commit 09178b4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 0 additions & 1 deletion django/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ html2text>=2016.9.19
jinja2==3.1.4
jsonschema==4.19.0
markdown==3.6
MarkupSafe<3.0.0 # FIXME: remove after regression in 3.0.x is patched https://github.com/comses/planning/issues/277
nltk>=3.8.1,<4.0.0
numpy==1.26.4
pandas==2.2.2
Expand Down
3 changes: 2 additions & 1 deletion e2e/cypress/tests/codebase.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ describe("Visit codebases page", () => {
getDataCy("codebase-associated-publications").type(codebase["associated-publications"]);
getDataCy("codebase-references").type(codebase.references);
getDataCy("next").click();

// make sure the release editor is initialized
cy.wait(2000);
//add images
getDataCy("add-image").click();
getDataCy("upload-image")
Expand Down

0 comments on commit 09178b4

Please sign in to comment.