Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some random small changes #107

Merged
merged 5 commits into from
Jan 20, 2024
Merged

Some random small changes #107

merged 5 commits into from
Jan 20, 2024

Conversation

tomers
Copy link

@tomers tomers commented Jan 20, 2024

Hey guys,

Could you please these reviews? There's some small things I've collected in the meanwhile.

Tomer Shalev added 5 commits January 19, 2024 16:49
Coding style
affe708 
No changes in content.
When saving in VS Code, it auto formats the file.
Support NoBackendError
9fee5a8 
This error probably only occurs when running inside docker container, since the host's USB is not shared with the docker.
Move GUI code into a separate sub directory
250074b 
It is rather confusing to have all files in the same directory.
GUI code depends on QtGui and is different from all other code.
Revert "Use Pathlib"
20b5ed5 
This reverts commit ddbf3f2.
The original code was better in both readability and the library coding
standard.
Dump traceback to the console
5436519 
In case of exception, the warnign dialog-box is not that useful when debugging, and it is much easier to read from console instead.
@maresb
Copy link
Collaborator

maresb commented Jan 20, 2024

Wonderful!!! Excellent work!

Two thoughts:

  1. I wonder if we should try to make the USB device accessible from the dev container. For example, a quick Google search turned up a SO thread with a few potential ideas. It would be nice, but it's not so big of a priority.
  2. The TOML formatting seems to come from the tamasfe.even-better-toml extension. Ideally we should enforce formatting with pre-commit, but there doesn't seem to exist a hook yet for the formatter used by that extension. I made a really quick feature request for it.

Thanks so much for moving this forward.

@maresb maresb merged commit e0f0029 into computerlyrik:master Jan 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomers @maresb