Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More comprehensive .gitignore file at repository root #222

Merged
merged 1 commit into from
Oct 4, 2023
Merged

More comprehensive .gitignore file at repository root #222

merged 1 commit into from
Oct 4, 2023

Conversation

GenevieveBuckley
Copy link
Collaborator

This PR:

  1. Adds the Github python gitignore template contents to our .gitignore file
  2. Adds a few extra files to the gitignore:
    • generated files related to code coverage measurements
    • .DS_Store files (I often work on a Mac)
    • any embeddings folders

I have not removed anything from the .gitignore (but I have made sure there are no duplicate entries, eg: __pycache__, etc.)
I also see that there are .gitignore files in subfolders of the repository, and I have not touched these at all either.

@GenevieveBuckley
Add github python gitignore contents, plus some extra files to ignore…
5518b4d 
… (code coverage, .DS_Store, embeddings, etc.)
@GenevieveBuckley GenevieveBuckley changed the base branch from master to dev October 4, 2023 06:22
@GenevieveBuckley GenevieveBuckley marked this pull request as ready for review October 4, 2023 06:23
constantinpape
constantinpape approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And I don't think we need to touch the .gitignore files in the subfolders, they are mostly there to not add the data that is automatically downloaded or created by the example scripts.

@constantinpape constantinpape merged commit 7408f48 into computational-cell-analytics:dev Oct 4, 2023
@GenevieveBuckley GenevieveBuckley deleted the gitignore branch October 5, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@constantinpape constantinpape constantinpape approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GenevieveBuckley @constantinpape