Skip to content

Commit

Permalink
Clean up
Browse files Browse the repository at this point in the history
  • Loading branch information
compulim committed Sep 9, 2021
1 parent 8d248d1 commit 694ee4b
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions packages/component/src/BasicTranscript.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ const InternalTranscript: VFC<InternalTranscriptProps> = ({ activityElementsRef,
// We only show the timestamp at the end of the sender group. But we always show the "Send failed, retry" prompt.
const renderActivityStatus = createActivityStatusRenderer({
activity,
nextVisibleActivity: undefined // TODO: Check this
nextVisibleActivity: undefined
});

const firstInSenderAndStatusGroup = !indexWithinSenderAndStatusGroup;
Expand Down Expand Up @@ -638,14 +638,6 @@ const InternalTranscript: VFC<InternalTranscriptProps> = ({ activityElementsRef,
[focusedActivityKey]
);

// TODO: Add test:
// 1. ~When focused on an <input> in a card, receive a proactive message, verify the scroll position should not move.~
// 2. ~When focused on any activity, receive a proactive message. Make sure the current focusing activity is continue to be focused.~

// TODO: Add test:
// 1. ~Focus on the transcript, set the 2nd last activity as focused. Receive a proactive message. Make sure the 2nd last activity is continue to be focused.~
// 2. ~Set the 2nd last activity as focused. Focus back to sendbox. Receive a proactive message. Make sure the new incoming activity is being selected.~

// If any activities has changed, reset the user-selected active descendant if the user is not focusing on the transcript or any descendants of transcript.
// This will assume the last activity, if any, will be the active descendant.
useEffect(() => {
Expand Down

0 comments on commit 694ee4b

Please sign in to comment.