Replace delete() with put(0) - delete is broken for forked vms #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jflatow
force-pushed
the
jflatow/unbreak-fork
branch
from
1a23aaa to
4c7e063
Compare
|
I'm having this exact issue. Any blockers on merging this? |
|
Folks. Please. It's been months not weeks |
achiko
added a commit
to achiko/ganache-core
that referenced
this pull request
Jul 18, 2020
|
Please merge this, Truffle! |
|
A generic solution was merged into the master repo in trufflesuite#612 |
|
Just wanted to let you know that it looks like we'll end up needing this solution to solve all the different use cases. I do think this is still a generic solution! Thanks again @jflatow for the work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete is deleting the storage locally, causing the fork to think it needs to re-fetch the data from the upstream the next time it is needed. This isn't correct since the value should actually be 0 after the delete.
This patch likely breaks the semantics around storage for e.g. Istanbul, so it's probably not the ultimate fix, however it fixes fork if needed, and includes a reproducible minimal example to test against.