Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EchoClient example #67

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

hezhenxing
Copy link
Contributor

No description provided.

@hezhenxing hezhenxing force-pushed the echoclient branch 3 times, most recently from cf858ed to b778b79 Compare April 25, 2024 01:11
@adithyaov
Copy link
Member

@hezhenxing
Thank you for the PR.
Looks like there is some problem with the CIs. I'll fix the CIs and review this.

examples/EchoClient.hs Outdated Show resolved Hide resolved
Copy link
Member

@adithyaov adithyaov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good. Can you keep only the version of echo that has pipeChunks?
The two implementations are semantically different with the implementation with pipeChunk winning.

@adithyaov
Copy link
Member

Can you also rebase on the latest master?

@hezhenxing
Copy link
Contributor Author

Done as requested, please take a look.

@harendra-kumar
Copy link
Member

@adithyaov can you please merge this.

@adithyaov
Copy link
Member

Apologies for the extremely delayed merge.
I'll be merging the PR into a branch and merge it back into master.

@adithyaov adithyaov changed the base branch from master to pr-hexhenzing November 18, 2024 07:24
@adithyaov adithyaov merged commit a84e873 into composewell:pr-hexhenzing Nov 18, 2024
1 check failed
@adithyaov adithyaov mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants