Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement array shapes for Preg::match $matches by-ref parameter #25

Merged
merged 15 commits into from
Jul 11, 2024

Conversation

Seldaek
Copy link
Member

@Seldaek Seldaek commented Jul 11, 2024

No description provided.

@Seldaek Seldaek force-pushed the stan-setup branch 2 times, most recently from 3b7bf94 to 757877d Compare July 11, 2024 09:18
@Seldaek
Copy link
Member Author

Seldaek commented Jul 11, 2024

@staabm can you maybe reset your branch off the one on my fork? This targets 2.x which would be preferable as Composer uses that still.

There are two problems:

I think these might just be outdated things causing problems, but I am not familiar enough to fix it so I'd appreciate if you can take a look.

@staabm
Copy link
Contributor

staabm commented Jul 11, 2024

I think the errors are related to the phpunit-bridge, see https://github.com/composer/pcre/pull/24/files#r1648824476

can we get rid of the bridge for composer/pcre 2.x?
I think it could in general simplify the CI setup in case we could use plain phpunit.

@Seldaek
Copy link
Member Author

Seldaek commented Jul 11, 2024

It now runs the phpstan tests without the bridge, so I don't think it's that.

image

@Seldaek Seldaek merged commit 37ef71e into composer:2.x Jul 11, 2024
11 of 12 checks passed
@Seldaek
Copy link
Member Author

Seldaek commented Jul 11, 2024

Alright, thanks @staabm !

@Seldaek Seldaek deleted the stan-setup branch July 11, 2024 11:34
@staabm
Copy link
Contributor

staabm commented Jul 11, 2024

excellent, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants