-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement array shapes for Preg::match $matches by-ref parameter #25
Conversation
3b7bf94
to
757877d
Compare
@staabm can you maybe reset your branch off the one on my fork? This targets 2.x which would be preferable as Composer uses that still. There are two problems:
I think these might just be outdated things causing problems, but I am not familiar enough to fix it so I'd appreciate if you can take a look. |
I think the errors are related to the phpunit-bridge, see https://github.com/composer/pcre/pull/24/files#r1648824476 can we get rid of the bridge for composer/pcre 2.x? |
Alright, thanks @staabm ! |
excellent, thank you |
No description provided.