Abandoning Packages #421
Abandoning Packages #421
Conversation
Added abandoned and replacementPackage properties to package Added visual queue to abandoned packages in view and list.
Added form to collect replacement package Added buttons for abandoning and un-abandoning packages
|
|
| @@ -34,6 +35,16 @@ | |||
| <input type="submit" value="Delete" /> | |||
| </form> | |||
| {% endif %} | |||
| {% if is_granted('ROLE_EDIT_PACKAGES') or package.maintainers.contains(app.user) and not package.abandoned %} | |||
| <form class="action abandon" action="{{ path('abandon_package', {name: package.name}) }}"> | |||
| <input type="submit" value="Abandon" /> | |||
There was a problem hiding this comment.
this won't work. you need either to render the form, or to make it a link to the page displaying the form rather than a form submitting invalid values
There was a problem hiding this comment.
It actually does work, its basically submitting the form via GET and since i need no variables other then the one in the action url, its just working as a link but holding the button styles of packagist. It can easily be replaced with a link or button, its the styling that will need work.
|
+1 (just to follow this request) |
|
Any further feedback? |
|
Sounds like a good idea. |
|
@Seldaek awesome, will try to get the composer side of this done asap. |
|
Why not allowing composer.json to contain that flag and just read from it? Makes more sense to me as that is the main repo for all the information. Sth like as new key? |
|
@rdohms alright, no stress ;) @dereuromark Not sure. I think it's easier on packagist because it allows admins to do it easily too, and can be supported by a user-based "report" system later on. Also it'd be too easy to end up with abandoned garbage in tags and stuff which I think it kinda nasty. |
|
génial, I'll try this asap too ! |
This PR adds the
abandonedflag to packages, allowing package owners to mark packages as no longer maintained.A replecement package can also be suggested and will be displayed along with the warning.
Abandoned packages appear normally but with a warning about its current state.
A un-abandon button is also available to revert.
Next steps: in composer we should make installing these packages throw a warning.
Closes #192.