feat: ClassMapGenerator::scanPaths can exclude specific dirs #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of composer#6 Class Finder from Symfony is used to get an iterator on files matching the first argument of scanPaths. Currently if we want to exclude some files from the search we can provide a regex which will be test on each file. Finder has a method exclude() which allow us to exclude a list of dirs relative to the one passed in in(). It does a pre-filtering much more efficient than checking the regex. To keep backward compatibility, this new argument is added at then end of the method with a default value.
|
Thanks for the changes. Is the phpstan errors on unchanged code normal? |
|
Yup ignore the errors, they're from new phpstan versions, I'll get those fixed on main later. |
|
As for the PR, thanks, looks good to me, but I do wonder in terms of implementing this in Composer perhaps.. if you pass in |
|
Seems like it is indeed an issue in symfony/finder.. symfony/symfony#47431 symfony/symfony#54752 |
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
Class Finder from Symfony is used to get an iterator on files matching the first argument of scanPaths. Currently if we want to exclude some files from the search we can provide a regex which will be test on each file.
Finder has a method exclude() which allow us to exclude a list of dirs relative to the one passed in in(). It does a pre-filtering much more efficient than checking the regex.
To keep backward compatibility, this new argument is added at then end of the method with a default value.