This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Gorequest may return nil values for responses #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an HTTP connection returns unsuccessfully, gorequest will return nil for the response object, so attempting to view the StatusCode will trigger a SIGSEGV panic(). It is therefore only safe to make that check after ensuring that the response is non-nil
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an HTTP connection returns unsuccessfully, gorequest will return nil for the response object, so attempting to view the StatusCode will trigger a SIGSEGV panic.
It is therefore only safe to make that check after ensuring that the response is non-nil
I have a code snippet that I used to track down the root of the panic, as well as verify that this fix works: https://gist.github.com/benjdewan/4941195e771a42f076383c95aaf796d8
When we hit this corner case the errors
gorequestmay return will never be properly processed byProcessErrorsbecause they are not returned by the compose API, but from within the gorequest library or one of its dependencies which is why the new code does not invoke that method.