Support nested variable expansion #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
LGTM assuming we get compose-spec/compose-spec#105 approved
|
@MarilynFranklin Could you please rebase the PR? It's conflicting on |
Signed-off-by: MarilynFranklin <[email protected]>
ulyssessouza
force-pushed
the
support-nested-variable-expansion
branch
from
5fa4fc9 to
8007e3c
Compare
|
Hello @MarilynFranklin! I've done the rebase for you. Hope you don't mind 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: MarilynFranklin [email protected]
This is my first pass at implementing nested variable expansion for consistency with changes proposed here
I ran into an
initialization looperror and ended up removingDefaultSubstituteFuncsto fix the issue. I suspect there may be a better way to solve that problem, but I'm pretty new to go!