Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect project dir is a symlink and warn user #702

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Oct 24, 2024

when ran from a symlink, while we find compose.yaml we run with a distinct project_dir and project_name. This might be user intent but also can cause unexpected behavior. This PR adds a sanity-check for such circumstances to warn user

closes docker/compose#12026

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit bff5006 into compose-spec:main Oct 24, 2024
8 checks passed
@ndeloof ndeloof deleted the symlink branch October 24, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] docker compose exec fails when projectdir is a symlink
2 participants