load configuration file with right ResourceLoader #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
force-pushed
the
554-use-resource-loader-to-ingest-compose-files
branch
from
7ba1cd6
to
95281eb
Compare
ndeloof
approved these changes
Oct 22, 2024
|
|
||
| for i, p := range configFiles { | ||
| for _, loader := range opts.ResourceLoaders { | ||
| _, isLocalResourceLoader := loader.(localResourceLoader) |
There was a problem hiding this comment.
if local loader reject Accept it's highly probable it will also fail on Load, so why not just let it reject path and get this function return an error if no loader accepted the path ?
There was a problem hiding this comment.
Yes but you won't have the reason why.
What I could do is changing the Accept signature to return an error in addition of the boolean, WDYT?
There was a problem hiding this comment.
the other option could be for localResource Loader to always accept path. The Load can return file not found error
There was a problem hiding this comment.
Ok I'll adapt the Accept function of resource loader
glours
force-pushed
the
554-use-resource-loader-to-ingest-compose-files
branch
2 times, most recently
from
aebbee9
to
b5c8e72
Compare
ndeloof
approved these changes
Oct 23, 2024
glours
force-pushed
the
554-use-resource-loader-to-ingest-compose-files
branch
4 times, most recently
from
a41bb55
to
0f71bc7
Compare
Signed-off-by: Matthew Humphreys <[email protected]>
and pass workdir to LoadConfigFiles func to setup ConfigDetails Signed-off-by: Guillaume Lours <[email protected]>
glours
force-pushed
the
554-use-resource-loader-to-ingest-compose-files
branch
from
0f71bc7
to
e16daf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect and use the right ResourceLoader to load a config file and add it
ConfigDetailsstruct.LocalResourceLoaderis always used as the last loader and should failed if it's not able to parse the configuration file.This PR replace #592