review processing of DeviceRequest due to Docker engine changes #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
approved these changes
Oct 1, 2024
moby/moby#48483 Signed-off-by: Guillaume Lours <[email protected]>
jhrotko
reviewed
Oct 2, 2024
| count: 2 | ||
| device_ids: ["my-device-id"] | ||
| `) | ||
| assert.ErrorContains(t, err, `invalid "count" and "device_ids" are attributes are exclusive`) |
There was a problem hiding this comment.
Suggested change
| assert.ErrorContains(t, err, `invalid "count" and "device_ids" are attributes are exclusive`) | |
| assert.ErrorContains(t, err, `invalid "count" and "device_ids", these attributes are exclusive`) |
| count: 2 | ||
| device_ids: ["my-device-id"] | ||
| `) | ||
| assert.ErrorContains(t, err, `invalid "count" and "device_ids" are attributes are exclusive`) |
There was a problem hiding this comment.
Question: why can't capabilities and device_ids be defined at the same time?
| } | ||
| d.Capabilities = caps | ||
| if driver, ok := v["driver"]; ok { | ||
| if val, ok := driver.(string); ok { |
There was a problem hiding this comment.
shouldn't JSON schema handle this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See moby/moby#48483
Fixes docker/docs#21026