improve warning message about version attribute #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
reviewed
Jun 20, 2024
loader/loader.go
Outdated
| @@ -89,7 +89,7 @@ var versionWarning []string | |||
|
|
|||
| func (o *Options) warnObsoleteVersion(file string) { | |||
| if !slices.Contains(versionWarning, file) { | |||
| logrus.Warning(fmt.Sprintf("%s: `version` is obsolete", file)) | |||
| logrus.Warning(fmt.Sprintf("%s: the attribute `version` is deprecated,it will be ignored, please remove it to avoid potential confusion", file)) | |||
There was a problem hiding this comment.
version is not deprecated. If we want to, need first to update https://github.com/compose-spec/compose-spec/blob/master/04-version-and-name.md.
glours
force-pushed
the
improve-version-deprecation-message
branch
from
6092521 to
da57db2
Compare
ndeloof
approved these changes
Jun 20, 2024
ndeloof
reviewed
Jun 20, 2024
loader/loader.go
Outdated
| @@ -89,7 +89,7 @@ var versionWarning []string | |||
|
|
|||
| func (o *Options) warnObsoleteVersion(file string) { | |||
| if !slices.Contains(versionWarning, file) { | |||
| logrus.Warning(fmt.Sprintf("%s: `version` is obsolete", file)) | |||
| logrus.Warning(fmt.Sprintf("%s: the attribute `version` is obsolete,it will be ignored, please remove it to avoid potential confusion", file)) | |||
There was a problem hiding this comment.
obsolete,it => obsolete, it
glours
force-pushed
the
improve-version-deprecation-message
branch
from
da57db2 to
f602a84
Compare
Signed-off-by: Guillaume Lours <[email protected]>
glours
force-pushed
the
improve-version-deprecation-message
branch
from
f602a84 to
38722de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #641