Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set COMPOSE_PROJECT_NAME #628

Merged
merged 1 commit into from
May 15, 2024

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented May 15, 2024

Always set COMPOSE_PROJECT_NAME based on project name being computed from various options.
This enforce COMPOSE_PROJECT_NAME interpolation always get the expected value

fixes docker/compose#11734

@ndeloof ndeloof requested review from milas and glours and removed request for milas May 15, 2024 15:43
@ndeloof ndeloof force-pushed the COMPOSE_PROJECT_NAME-p branch from f01b674 to cfb8466 Compare May 15, 2024 15:44
Signed-off-by: Nicolas De Loof <[email protected]>
@ndeloof ndeloof force-pushed the COMPOSE_PROJECT_NAME-p branch from cfb8466 to 97d7144 Compare May 15, 2024 15:54
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit ba6d569 into compose-spec:main May 15, 2024
8 checks passed
@ndeloof ndeloof deleted the COMPOSE_PROJECT_NAME-p branch May 16, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants