validate merge result vs individual overrides #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
validation
branch
2 times, most recently
from
af061d7 to
e150b9f
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An override file doesn't need to respect all json schema rules, as long as the merge result is correct
This PR changes the logic so we validate merged model. Doing so we can use a partial compose.override.yaml file but still will detect incorrect usage as this validation will take place after each and every merge (including the first compose.yaml file load)
this PR changes:
grouping x-* fields into
#extensionsonly takes place just before we map to go struct. yaml dict uses the plain extension fields. For this purpose, mapstructure annotations is updated to omit emptyExtensionsattribute(s)