Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with additional_context short syntax #527

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Jan 15, 2024

need to convert additional_context to canonical (mapping) syntax before relative paths get resolved

closes docker/compose#11351

@ndeloof ndeloof force-pushed the regression_additional_context branch 3 times, most recently from ecbdd42 to a637e36 Compare January 15, 2024 16:10
Copy link
Collaborator

@jhrotko jhrotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof force-pushed the regression_additional_context branch from a637e36 to 913b640 Compare January 15, 2024 17:06
@ndeloof ndeloof enabled auto-merge (rebase) January 15, 2024 17:06
@ndeloof ndeloof merged commit 32d5bda into compose-spec:main Jan 15, 2024
8 checks passed
@ndeloof ndeloof deleted the regression_additional_context branch January 15, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 2.24.0 regression: additional build contexts do not work
2 participants