Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore support for escaped quoted char #511

Merged
merged 1 commit into from
Dec 18, 2023
Merged

restore support for escaped quoted char #511

merged 1 commit into from
Dec 18, 2023

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Dec 18, 2023

@ndeloof ndeloof requested review from glours and laurazard December 18, 2023 09:38
glours
glours approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit 81e1e90 into compose-spec:main Dec 18, 2023
8 checks passed
@ndeloof ndeloof deleted the escape_quote branch December 18, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours glours approved these changes

@laurazard laurazard Awaiting requested review from laurazard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Escape character appears in final value when escaping single quotes in environment file
2 participants
@ndeloof @glours