Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a network-scoped mac_address field #491

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Add a network-scoped mac_address field #491

merged 1 commit into from
Nov 20, 2023

Conversation

akerouanton
Copy link
Contributor

@akerouanton akerouanton commented Nov 20, 2023 •
edited
Loading

@akerouanton akerouanton requested a review from ndeloof as a code owner November 20, 2023 09:24
ndeloof
ndeloof reviewed Nov 20, 2023
View reviewed changes
schema/compose-spec.json Outdated
"mac_address": {"type": "string"},
"mac_address": {
"type": "string",
"deprecated": true
Copy link
Collaborator

@ndeloof ndeloof Nov 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any change to the schema must first be introduced in compose-spec/compose-spec
please include this change on compose-spec/compose-spec#435

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean docker run --mac-address is deprecated ?

@akerouanton akerouanton force-pushed the endpoint-specific-mac-address branch from 973331b to 7c47367 Compare November 20, 2023 11:20
@akerouanton akerouanton requested a review from ndeloof November 20, 2023 11:21
@akerouanton akerouanton force-pushed the endpoint-specific-mac-address branch from 7c47367 to 0282c0c Compare November 20, 2023 15:29
glours
glours approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 9be5f96 into compose-spec:main Nov 20, 2023
8 checks passed
@akerouanton akerouanton deleted the endpoint-specific-mac-address branch November 20, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours glours approved these changes

@ndeloof ndeloof ndeloof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akerouanton @ndeloof @glours