Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate watch.path is set to a valid path #490

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Nov 16, 2023

this bump compose-spec schema (watch and path are required) + adds a validation step to check the configured path exists

closes docker/compose#11182

@ndeloof ndeloof force-pushed the watch_path_required branch from 35f5c58 to 2f59e08 Compare November 16, 2023 14:43
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit e058570 into compose-spec:main Nov 16, 2023
8 checks passed
@ndeloof ndeloof deleted the watch_path_required branch November 16, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] watch watch's root even if that is not specified
2 participants