make scale a *int as default is 1 (not 0) #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
scale_default
branch
5 times, most recently
from
1352ed4 to
4007b07
Compare
milas
approved these changes
Nov 20, 2023
ndeloof
force-pushed
the
scale_default
branch
from
4007b07 to
0b26947
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
scale_default
branch
from
0b26947 to
7fe622d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as default is not 0,
omitemptydoesn't apply and this require code to manage this default value.using an
*intwe can distinguish unset value (scale=1) vs service explicitly set to scale=0 (many users rely on this to disable service)