Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for multi-document yaml #451

Merged
merged 1 commit into from
Aug 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 75 additions & 49 deletions loader/loader.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@
package loader

import (
"bytes"
"context"
"fmt"
"io"
"os"
paths "path"
"path/filepath"
Expand Down Expand Up @@ -166,7 +168,9 @@ func WithProfiles(profiles []string) func(*Options) {
// ParseYAML reads the bytes from a file, parses the bytes into a mapping
// structure, and returns it.
func ParseYAML(source []byte) (map[string]interface{}, error) {
m, _, err := parseYAML(source)
r := bytes.NewReader(source)
decoder := yaml.NewDecoder(r)
m, _, err := parseYAML(decoder)
return m, err
}

Expand All @@ -179,11 +183,11 @@ type PostProcessor interface {
Apply(config *types.Config) error
}

func parseYAML(source []byte) (map[string]interface{}, PostProcessor, error) {
func parseYAML(decoder *yaml.Decoder) (map[string]interface{}, PostProcessor, error) {
var cfg interface{}
processor := ResetProcessor{target: &cfg}

if err := yaml.Unmarshal(source, &processor); err != nil {
if err := decoder.Decode(&processor); err != nil {
return nil, nil, err
}
stringMap, ok := cfg.(map[string]interface{})
Expand Down Expand Up @@ -251,67 +255,86 @@ func load(ctx context.Context, configDetails types.ConfigDetails, opts *Options,
loaded = append(loaded, mainFile)

includeRefs := make(map[string][]types.IncludeConfig)
for i, file := range configDetails.ConfigFiles {
first := true
for _, file := range configDetails.ConfigFiles {
var postProcessor PostProcessor
configDict := file.Config
if configDict == nil {
if len(file.Content) == 0 {
content, err := os.ReadFile(file.Filename)
if err != nil {
return nil, err

processYaml := func() error {
if !opts.SkipValidation {
if err := schema.Validate(configDict); err != nil {
return fmt.Errorf("validating %s: %w", file.Filename, err)
}
file.Content = content
}
dict, p, err := parseConfig(file.Content, opts)

configDict = groupXFieldsIntoExtensions(configDict)

cfg, err := loadSections(ctx, file.Filename, configDict, configDetails, opts)
if err != nil {
return nil, fmt.Errorf("parsing %s: %w", file.Filename, err)
return err
}
configDict = dict
file.Config = dict
configDetails.ConfigFiles[i] = file
postProcessor = p
}

if !opts.SkipValidation {
if err := schema.Validate(configDict); err != nil {
return nil, fmt.Errorf("validating %s: %w", file.Filename, err)
if !opts.SkipInclude {
var included map[string][]types.IncludeConfig
cfg, included, err = loadInclude(ctx, file.Filename, configDetails, cfg, opts, loaded)
if err != nil {
return err
}
for k, v := range included {
includeRefs[k] = append(includeRefs[k], v...)
}
}
}

configDict = groupXFieldsIntoExtensions(configDict)

cfg, err := loadSections(ctx, file.Filename, configDict, configDetails, opts)
if err != nil {
return nil, err
}

if !opts.SkipInclude {
var included map[string][]types.IncludeConfig
cfg, included, err = loadInclude(ctx, file.Filename, configDetails, cfg, opts, loaded)
if first {
first = false
model = cfg
return nil
}
merged, err := merge([]*types.Config{model, cfg})
if err != nil {
return nil, err
return err
}
for k, v := range included {
includeRefs[k] = append(includeRefs[k], v...)
if postProcessor != nil {
err = postProcessor.Apply(merged)
if err != nil {
return err
}
}
model = merged
return nil
}

if i == 0 {
model = cfg
continue
}
if configDict == nil {
if len(file.Content) == 0 {
content, err := os.ReadFile(file.Filename)
if err != nil {
return nil, err
}
file.Content = content
}

merged, err := merge([]*types.Config{model, cfg})
if err != nil {
return nil, err
}
if postProcessor != nil {
err = postProcessor.Apply(merged)
if err != nil {
r := bytes.NewReader(file.Content)
decoder := yaml.NewDecoder(r)
for {
dict, p, err := parseConfig(decoder, opts)
if err != nil {
if err != io.EOF {
return nil, fmt.Errorf("parsing %s: %w", file.Filename, err)
}
break
}
configDict = dict
postProcessor = p

if err := processYaml(); err != nil {
return nil, err
}
}
} else {
if err := processYaml(); err != nil {
return nil, err
}
}
model = merged
}

project := &types.Project{
Expand Down Expand Up @@ -449,8 +472,8 @@ func NormalizeProjectName(s string) string {
return strings.TrimLeft(s, "_-")
}

func parseConfig(b []byte, opts *Options) (map[string]interface{}, PostProcessor, error) {
yml, postProcessor, err := parseYAML(b)
func parseConfig(decoder *yaml.Decoder, opts *Options) (map[string]interface{}, PostProcessor, error) {
yml, postProcessor, err := parseYAML(decoder)
if err != nil {
return nil, nil, err
}
Expand Down Expand Up @@ -757,7 +780,10 @@ func loadServiceWithExtends(ctx context.Context, filename, name string, services
return nil, err
}

baseFile, _, err := parseConfig(b, opts)
r := bytes.NewReader(b)
decoder := yaml.NewDecoder(r)

baseFile, _, err := parseConfig(decoder, opts)
if err != nil {
return nil, err
}
Expand Down
16 changes: 16 additions & 0 deletions loader/loader_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2737,3 +2737,19 @@ services:
})
assert.ErrorContains(t, err, "Circular reference")
}

func TestLoadMulmtiDocumentYaml(t *testing.T) {
project, err := loadYAML(`
name: load-multi-docs
services:
test:
image: nginx:latest
---
services:
test:
image: nginx:override

`)
assert.NilError(t, err)
assert.Equal(t, project.Services[0].Image, "nginx:override")
}