Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ability to convert a mapping (back) to KEY=VALUE strings #445

Merged
merged 1 commit into from
Aug 17, 2023
Merged

ability to convert a mapping (back) to KEY=VALUE strings #445

merged 1 commit into from
Aug 17, 2023

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Aug 17, 2023 •
edited
Loading

milas
milas requested changes Aug 17, 2023
View reviewed changes
Copy link
Member

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can we get a unit test? 😇

types/types.go Show resolved Hide resolved
@ndeloof ndeloof requested a review from milas August 17, 2023 14:03
@milas milas merged commit e5265c8 into compose-spec:master Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milas milas milas approved these changes

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza

@laurazard laurazard Awaiting requested review from laurazard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndeloof @milas