loader: restore implicit default of . for build context
#423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Compose spec, as well as Compose v1.x, the `build.context` field is mandatory in the object form of a `service.build` definition. However, in compose-go (and thus Compose v2.x), this has never been enforced, and an empty `build.context` field was implicitly set to `.` aka the project directory. Restore that behavior pending a decision on whether we want to make the spec less restrictive here so that this is acceptable or change `compose-go` to begin emitting a warning and eventually reject this. Note that the order of normalization and resolving paths has been switched so that normalization occurs first, and then paths can be resolved across all fields consistently. This resulted in a small test update where this was incorrect before - it was loading with path resolution enabled but then asserting it had a relative path for the env file. Signed-off-by: Milas Bowman <[email protected]>
milas
force-pushed
the
restore-default-context-behavior
branch
from
e00bd85 to
4719844
Compare
ndeloof
approved these changes
Jun 29, 2023
laurazard
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Compose spec, as well as Compose v1.x, the
build.contextfield is mandatory in the object form of aservice.builddefinition.However, in compose-go (and thus Compose v2.x), this has never been enforced, and an empty
build.contextfield was implicitly set to.aka the project directory.Restore that behavior pending a decision on whether we want to make the spec less restrictive here so that this is acceptable or change
compose-goto begin emitting a warning and eventually reject this.Note that the order of normalization and resolving paths has been switched so that normalization occurs first, and then paths can be resolved across all fields consistently. This resulted in a small test update where this was incorrect before - it was loading with path resolution enabled but then asserting it had a relative path for the env file.
https://docker.atlassian.net/browse/ENV-239