Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve dotenv error messages #421

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

nicks
Copy link
Contributor

@nicks nicks commented Jun 23, 2023

  • print the variable name that failed to parse
  • print the name of the file where the syntax error appeared

@nicks nicks requested a review from ndeloof as a code owner June 23, 2023 17:47
@nicks
Copy link
Contributor Author

nicks commented Jun 23, 2023

the validation failure doesn't seem related to my pr -- not sure what's going on.

@nicks
Copy link
Contributor Author

nicks commented Jun 23, 2023

ah, i see, it's waiting on #420 to be merged

dotenv/parser.go Outdated Show resolved Hide resolved
@nicks nicks requested a review from ndeloof June 26, 2023 13:54
- print the variable name that failed to parse
- print the name of the file where the syntax error appeared

Signed-off-by: Nick Santos <[email protected]>
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 46dcfae into compose-spec:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants