introduce ResolveRelativePaths as a distinct operation vs Normalization #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
relative_paths
branch
2 times, most recently
from
96d3404 to
ea79f1e
Compare
milas
reviewed
Jun 2, 2023
Signed-off-by: Nicolas De Loof <[email protected]>
milas
approved these changes
Jun 7, 2023
tomfeigin
reviewed
Jun 30, 2023
| @@ -185,6 +185,7 @@ func Load(configDetails types.ConfigDetails, options ...func(*Options)) (*types. | |||
| LookupValue: configDetails.LookupEnv, | |||
| TypeCastMapping: interpolateTypeCastMapping, | |||
| }, | |||
| ResolvePaths: true, | |||
There was a problem hiding this comment.
@ndeloof this is a change in default behavior right? Before this was false by default.
If I explicitly set it to false through the options argument of the Load function the behavior would be the same as before this change right?
There was a problem hiding this comment.
The 'ResolvePaths' make the unit-test fail in the nerdctl :-)
relate : containerd/nerdctl#2338
There was a problem hiding this comment.
@tomfeigin code that has been moved into ResolveRelativePaths used to be inside Normalize which is enabled until you explicitly set SkipNormalization, so this is not a behavior change. Just those two processing aspects have been separated into distinct flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalizationis used both to define implicit resources and to resolve relative paths, so it brings a parameter so apply load optionResolvePathsthis PR introduces and explicit
ResolveRelativePathsto manage this option as an explicit load operationthis also allows to avoid duplicating the code when loading service
extendsand resolving basefile-relative paths