dependabot: disable version bump checks/only keep security updates #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go uses a minimal version selection algorithm to select the version of modules used in a build (see https://github.com/golang/go/wiki/Modules#version-selection). From the go wiki: ``` [...] if your module depends on module A which has a require D v1.0.0, and your module also depends on module B which has a require D v1.1.1, then minimal version selection would choose v1.1.1 of D to include in the build (given it is the highest listed require version). ``` Since `compose-go` is a library and meant to be used by downstream implementations, in order to maximize compatibility with other imports we should try to use the lowest version of any dependencies we need, as opposed to using whatever latest version is available. This commit changes the dependabot config to disable version bumps, but does keep security updates enabled. (see: https://docs.github.com/en/code-security/dependabot/dependabot-security-updates/configuring-dependabot-security-updates) Signed-off-by: Laura Brehm <[email protected]>
milas
approved these changes
May 23, 2023
There was a problem hiding this comment.
I agree with limiting dependabot to security updates here to keep churn/noise low.
In general though, I'd still advocate for bumping to latest dependency versions regularly. I realize there's no "winning" answer here, but IMO depending on old versions (and thus testing against them) is likely to result in more downstream issues than the other way around.
glours
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go uses a minimal version selection algorithm to select the version of modules used in a build (see https://github.com/golang/go/wiki/Modules#version-selection).
From the go wiki:
Since
compose-gois a library and meant to be used by downstream implementations, in order to maximize compatibility with other imports we should try to use the lowest version of any dependencies we need, as opposed to using whatever latest version is available.This commit changes the dependabot config to disable version bumps, keeping security updates enabled.
(see: https://docs.github.com/en/code-security/dependabot/dependabot-security-updates/configuring-dependabot-security-updates)