Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix regression considering volumes-from: container a dependency #384

Merged
merged 1 commit into from
Apr 7, 2023
Merged

fix regression considering volumes-from: container a dependency #384

merged 1 commit into from
Apr 7, 2023

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Apr 4, 2023

glours
glours requested changes Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, we should just add a test case for volumes_from with a service name

loader/normalize_test.go Show resolved Hide resolved
loader/normalize_test.go
@@ -220,6 +223,7 @@ services:
default: null
volumes_from:
- zot
- container:xxx
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- container:xxx
- service:yyy"
- container:xxx

milas
milas approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@glours glours merged commit 1af0f42 into compose-spec:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milas milas milas approved these changes

@glours glours glours approved these changes

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza

@laurazard laurazard Awaiting requested review from laurazard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ndeloof @glours @milas