ignore .env can't be read if not explicitly set by user #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
dotEnv
branch
2 times, most recently
from
bbce9c3 to
b1ae8d9
Compare
milas
approved these changes
Apr 11, 2023
cli/options_test.go
Outdated
| func TestGetEnvFromFile(t *testing.T) { | ||
| wd := t.TempDir() | ||
| f := filepath.Join(wd, ".env") | ||
| err := os.Mkdir(f, 0700) |
There was a problem hiding this comment.
Suggested change
| err := os.Mkdir(f, 0700) | |
| err := os.Mkdir(f, 0o700) |
to make the linter happy
Signed-off-by: Nicolas De Loof <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes docker/compose#10430
added a test case so we don't re-introduce this regression in the future
I'm a bit sad we can't (in a portable way) just check err == EISDIR after
os.ReadFileand need to preventively checkos.Stat.