add support for build.privileged and service.cgroup #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
requested changes
Dec 20, 2022
types/types.go
Outdated
| @@ -354,12 +356,12 @@ type ThrottleDevice struct { | |||
| // ShellCommand is a string or list of string args. | |||
| // | |||
| // When marshaled to YAML, nil command fields will be omitted if `omitempty` | |||
| // is specified as a struct tag. Explicitly empty commands (i.e. `[]` or `''`) | |||
| // is specified as a struct tag. Explicitly empty commands (i.e. `[]` or `”`) | |||
There was a problem hiding this comment.
@ndeloof you're IDE again?
Suggested change
| // is specified as a struct tag. Explicitly empty commands (i.e. `[]` or `”`) | |
| // is specified as a struct tag. Explicitly empty commands (i.e. `[]` or `''`) |
There was a problem hiding this comment.
😓 I thought I found the right option to prevent this.
types/types.go
Outdated
| // will serialize to an empty array (`[]`). | ||
| // | ||
| // When marshaled to JSON, the `omitempty` struct must NOT be specified. | ||
| // If the command field is nil, it will be serialized as `null`. | ||
| // Explicitly empty commands (i.e. `[]` or `''`) will serialize to an empty | ||
| // Explicitly empty commands (i.e. `[]` or `”`) will serialize to an empty |
There was a problem hiding this comment.
same?
Suggested change
| // Explicitly empty commands (i.e. `[]` or `”`) will serialize to an empty | |
| // Explicitly empty commands (i.e. `[]` or `''`) will serialize to an empty |
Signed-off-by: Nicolas De Loof <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.