Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve warning message #328

Merged
merged 1 commit into from
Dec 19, 2022
Merged

improve warning message #328

merged 1 commit into from
Dec 19, 2022

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Dec 18, 2022

@ndeloof
improve warning message
c5ef323 
Signed-off-by: Nicolas De Loof <[email protected]>
@ndeloof ndeloof force-pushed the network.external.name branch from ad8dbe8 to c5ef323 Compare December 18, 2022 21:48
laurazard
laurazard approved these changes Dec 18, 2022
View reviewed changes
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit 5f02fe7 into compose-spec:master Dec 19, 2022
@ndeloof ndeloof deleted the network.external.name branch December 19, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurazard laurazard laurazard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update deprecated feature warning with steps to correct behavior
2 participants
@ndeloof @laurazard