Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore variable names starting with numbers #284

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Ignore variable names starting with numbers #284

merged 1 commit into from
Jul 22, 2022

Conversation

ulyssessouza
Copy link
Contributor

No description provided.

@ulyssessouza ulyssessouza force-pushed the fix-numeric-named-vars branch 2 times, most recently from 4c86d19 to 55f898e Compare July 12, 2022 22:33
@ulyssessouza ulyssessouza marked this pull request as ready for review July 12, 2022 22:35
nicksieger
nicksieger reviewed Jul 13, 2022
View reviewed changes
dotenv/godotenv.go Outdated Show resolved Hide resolved
nicksieger
nicksieger approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@nicksieger nicksieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

milas
milas approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This has come up before, but at some point we should formalize valid env var names in the spec, and then could probably make this an allow regex instead of a deny. But this is a good improvement as-is!

laurazard
laurazard approved these changes Jul 17, 2022
View reviewed changes
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit c796fcc into master Jul 22, 2022
@glours glours deleted the fix-numeric-named-vars branch July 22, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicksieger nicksieger nicksieger approved these changes

@glours glours glours approved these changes

@milas milas milas approved these changes

@laurazard laurazard laurazard approved these changes

@ndeloof ndeloof Awaiting requested review from ndeloof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ulyssessouza @nicksieger @glours @milas @laurazard