-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix environment variable expansion #276
Conversation
Signed-off-by: Ulysses Souza <[email protected]>
Signed-off-by: Ulysses Souza <[email protected]>
fb94264
to
3844ce4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested against the Compose unit & e2e tests with success!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -0,0 +1,154 @@ | |||
package dotenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 for these test cases!
case "$": | ||
return "$$" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤑
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <[email protected]>
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <[email protected]>
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <[email protected]>
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <[email protected]> (cherry picked from commit de563c1)
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <[email protected]>
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <[email protected]> Co-authored-by: Javier Marcet <[email protected]>
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <[email protected]> (cherry picked from commit de563c1)
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <[email protected]>
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <[email protected]> (cherry picked from commit de563c1)
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <[email protected]> (cherry picked from commit de563c1)
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <[email protected]> (cherry picked from commit de563c1)
No description provided.