Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for secret set by environment variable #263

Merged
merged 1 commit into from
May 30, 2022
Merged

add support for secret set by environment variable #263

merged 1 commit into from
May 30, 2022

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented May 18, 2022

glours
glours reviewed May 18, 2022
View reviewed changes
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me but can we add a test?

@ndeloof
Copy link
Collaborator Author

ndeloof commented May 18, 2022

updated with a test-case, + added consistency check that a secret should have either file or environment set if it is not external.

glours
glours approved these changes May 18, 2022
View reviewed changes
Copy link
Collaborator

@glours glours left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the test 😉

@ndeloof ndeloof merged commit 5bab6eb into compose-spec:master May 30, 2022
@ndeloof ndeloof deleted the env_secret branch May 30, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours glours approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndeloof @glours