Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a typo in GroupAdd type mapping #201

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

axhav
Copy link

@axhav axhav commented Nov 3, 2021

Found an issue that GroupAdd was not working with docker compose v2. This typo fix should restore "group_add" parameter to docker compose again.

Fixes docker/compose#8810

Signed-off-by: William Axhav Bratt [email protected]

@axhav axhav requested a review from ndeloof as a code owner November 3, 2021 11:21
Copy link
Contributor

@mat007 mat007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch, thanks!

@mat007
Copy link
Contributor

mat007 commented Nov 3, 2021

…sulting in GroupAdd not working

Signed-off-by: William Axhav Bratt <[email protected]>
@axhav
Copy link
Author

axhav commented Nov 3, 2021

Thanks for the quick reply, signing should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compose v2 does not respect the group_add field
2 participants