embed schema.json using go 1.16 support for static resources #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
embed
branch
5 times, most recently
from
8f26ce7 to
4921014
Compare
chris-crone
reviewed
Feb 17, 2021
.github/workflows/ci.yml
Outdated
| @@ -16,13 +16,13 @@ jobs: | |||
| test: | |||
| strategy: | |||
| matrix: | |||
| go-version: [1.13.x, 1.14.x] | |||
| go-version: [1.16.0] | |||
There was a problem hiding this comment.
We should make this float with patch releases.
Suggested change
| go-version: [1.16.0] | |
| go-version: [1.16.x] |
| @@ -87,7 +87,7 @@ | |||
| "dockerfile": {"type": "string"}, | |||
| "args": {"$ref": "#/definitions/list_or_dict"}, | |||
| "labels": {"$ref": "#/definitions/list_or_dict"}, | |||
| "cache_from": {"$ref": "#/definitions/list_of_strings"}, | |||
| "cache_from": {"type": "array", "items": {"type": "string"}}, | |||
There was a problem hiding this comment.
Were the changes to the schema intentional?
There was a problem hiding this comment.
I used the latest from compose-spec repo
Signed-off-by: Nicolas De Loof <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
embedpackage add support for embedding static resources without relying on code generationhttps://golang.org/pkg/embed/