Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Decode errors are ignored #512

Closed
lionello opened this issue Dec 20, 2023 · 0 comments
Closed

Regression: Decode errors are ignored #512

lionello opened this issue Dec 20, 2023 · 0 comments

Comments

@lionello
Copy link
Contributor

lionello commented Dec 20, 2023 •
edited
Loading

Regression introduced in 7e391a6 @ndeloof

compose-go/loader/loader.go

Line 342 in 7e391a6

err := decoder.Decode(processor)

This piece of code got deleted:

7e391a6#diff-8e9af1e483632eac17610237caaa5f879ea7bfb3e1e1ea228e45a17c770b9432L303-L305
lionello added a commit to DefangLabs/compose-go that referenced this issue Dec 20, 2023
@lionello
fix compose-spec#512 revert err check
e1304dd
lionello added a commit to DefangLabs/compose-go that referenced this issue Dec 20, 2023
@lionello
fix compose-spec#512 revert err check
75ccc65 
Signed-off-by: Lionello Lunesu <[email protected]>
lionello added a commit to DefangLabs/compose-go that referenced this issue Dec 20, 2023
@lionello
fix compose-spec#512 revert err check
061c4d7 
Signed-off-by: Lionello Lunesu <[email protected]>
aksiksi pushed a commit to aksiksi/compose-go that referenced this issue Dec 21, 2023
@lionello @aksiksi
fix compose-spec#512 revert err check
3024ba6 
Signed-off-by: Lionello Lunesu <[email protected]>
aksiksi pushed a commit to aksiksi/compose-go that referenced this issue Dec 21, 2023
@lionello @aksiksi
fix compose-spec#512 revert err check
408b401 
Signed-off-by: Lionello Lunesu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lionello