Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package to ember-data #38

Closed
wants to merge 1 commit into from
Closed

Conversation

xcambar
Copy link

@xcambar xcambar commented Dec 30, 2016

refs #37
Declares the package private so it can not be published to npm (it is already not published).

This allows to use various versions of ember-data easier, most notably with ember-try configs.

Declares the package as private to avoid conflicts with the official `ember-data`
@xcambar xcambar mentioned this pull request Dec 30, 2016
@rwjblue
Copy link
Contributor

rwjblue commented Dec 30, 2016

I do not understand the motivation here, ember-data is already published to NPM and this repo is largely supporting those folks who are still consuming via bower.

Why not just use ember-try to pull ember-data from NPM?

@xcambar
Copy link
Author

xcambar commented Dec 30, 2016

Using npm, this can be done:

      npm: {
        devDependencies: {
          'ember-data': '#latest', // currently `2.10.0`
          'ember-data': '#beta' // currently `2.11.0-beta.1`
        }
      },

How would I configure ember-data as an npm dep so it fetches the canary channel?
To my knowledge, the same issue will apply after 2.11.0 with the ember-source package, for which the dist-tags are currently { latest: '2.11.0-beta.2', beta: '2.11.0-beta.1' }

Does it help?

@rwjblue
Copy link
Contributor

rwjblue commented Dec 30, 2016

Canary:

"ember-data": "emberjs/data#master",

Beta:

"ember-data": "emberjs/data#beta",

Release:

"ember-data": "emberjs/data#release",

@rwjblue
Copy link
Contributor

rwjblue commented Dec 30, 2016

To my knowledge, the same issue will apply after 2.11.0 with the ember-source package

Yes, ember-source will have the issue that you describe (at least at the moment it does). The difference between ember-data and ember-source in this regard is that ember-data is a "normal" addon and it manages its own build at ember-cli app build time, whereas ember-source still relies on pre-built assets. We are working towards fixing this though, and hopefully will have it fixed soonish into the 2.12 beta cycle.

@xcambar
Copy link
Author

xcambar commented Dec 30, 2016

Thanks for the clarification! Works perfectly!
I'll let you close the PR, in case you'd think there's more to be discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants