Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

Follow the chain of paths for local dependencies #337

Closed

Conversation

micky2be
Copy link
Contributor

Look for local chain of dependencies based on parent dependencies path list.
Kept the pathfrom the root component.json during the lookup for backward compatibility

@micky2be
Copy link
Contributor Author

Include fix from #336

@micky2be
Copy link
Contributor Author

micky2be commented Jun 3, 2013

@visionmedia > Let me know if you wanna me to do any change on this

@tj
Copy link
Contributor

tj commented Jun 7, 2013

hmm a test would be good if possible, locals were not influenced by the parent's .paths before this? should be

@micky2be
Copy link
Contributor Author

micky2be commented Jun 7, 2013

Will make a test then.
But if you look at #324, you will see I'm not the only one having the problem

@micky2be
Copy link
Contributor Author

micky2be commented Jun 7, 2013

@visionmedia Added a test to replicate our problem

@dominicbarnes
Copy link
Contributor

+1

I just ran into this problem and merging in this branch solves it for me.

@micky2be
Copy link
Contributor Author

@dominicbarnes I'm glad it fixed your problem

@tj
Copy link
Contributor

tj commented Jun 11, 2013

test doesn't pass (missing component.json) but ill take a look

@micky2be
Copy link
Contributor Author

Weird, I may have messed up during a merge or something.
I pushed a fix anyways

@tj
Copy link
Contributor

tj commented Jun 18, 2013

still fails for me, there's no component.json:

SyntaxError: /Users/tj/projects/component/test/fixtures/local/component.json: Unexpected end of input
    at Object.parse (native)
    at Object.Module._extensions..json (module.js:475:27)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:362:17)
    at require (module.js:378:17)
    at loadConfig (/Users/tj/projects/component/bin/component-install:246:12)
    at Object.<anonymous> (/Users/tj/projects/component/bin/component-install:71:12)
    at Module._compile (module.js:449:26)
    at Object.Module._extensions..js (module.js:467:10)

@micky2be
Copy link
Contributor Author

It's not like I wanna to pression on @visionmedia but this is getting old.

@tj
Copy link
Contributor

tj commented Jun 18, 2013

well this is causing me more work than just fixing it haha, usually people run their own tests first :p

@micky2be
Copy link
Contributor Author

Oh! The file was ignored by git. Pushing now

@tj
Copy link
Contributor

tj commented Jun 19, 2013

damn, still missing the other ones, master has !test/fixtures/**/component.json in the .gitignore now so it should be less annoying that way, but "direct" and the other two are missing for me as well

@micky2be
Copy link
Contributor Author

Git didn't see those even with the .gitignore update.
Gonna force them

On Jun 19, 2013, at 9:04, TJ Holowaychuk [email protected] wrote:

damn, still missing the other ones, master has
!test/fixtures/**/component.json in the .gitignore now so it should be less
annoying that way, but "direct" and the other two are missing for me as well


Reply to this email directly or view it on
GitHubhttps://github.com//pull/337#issuecomment-19651762
.

@micky2be
Copy link
Contributor Author

Sorry for the delay, I had to do it from my phone

@tj
Copy link
Contributor

tj commented Jun 19, 2013

hahaha that can't be too easy, thanks man

@micky2be micky2be closed this Jun 20, 2013
@mikerudolph
Copy link

What is the status on this fix? I don't see it ever being merged?

@micky2be
Copy link
Contributor Author

It's in since v0.16.4

@mikerudolph
Copy link

I am still seeing this issue while running on latest, should I open a new issue?

@micky2be
Copy link
Contributor Author

Not having any problems on my side. You sure all your paths are correct?
If you really have a problem you should definitely open an issue.
Don 't forget to mention versions (component, node), and describe your use case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants