Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM release for 0.0.3 and master changes #6

Open
kylef opened this issue Apr 10, 2018 · 0 comments
Open

NPM release for 0.0.3 and master changes #6

kylef opened this issue Apr 10, 2018 · 0 comments

Comments

@kylef
Copy link

kylef commented Apr 10, 2018 •
edited
Loading

Hi,

I spotted some licensing problems with this package that seem to have been resolved in #4 and #5, but an updated NPM package hasn't been released. NPM has the latest version of 0.0.1 (where repo has 0.0.3).

Would we be able to get 0.0.3 published on NPM and perhaps a new release including #5 in the NPM package.

EDIT, seems there is two NPM packages indexof and component-indexof and this repository is for both. The latter has a 0.0.3 release but doesn't contain a LICENSE.
@kylef kylef mentioned this issue Apr 10, 2018
Closed
14 tasks
fahrradflucht added a commit to fahrradflucht/node-libs-browser that referenced this issue Apr 27, 2018
@fahrradflucht
chore: upgrade vm-browserify to 1.0.1
1b24f34 
vm-browserify up until 1.0.1 dependy upon unlicensed code. [0][1] This means
node-libs-browser does too. This resolves the issue by upgrading it. All
changes in between where non-breaking. [2]

[0] browserify/browserify#1828
[1] component/indexof#6
[2] https://github.com/browserify/vm-browserify/releases
@fahrradflucht fahrradflucht mentioned this issue Apr 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kylef