Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current fullscreen state. #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shallker
Copy link

@shallker shallker commented Sep 9, 2013

Useful for switching between fullscreen:
function onKeyup(ev) {
if (ev.keyCode !== 75) return;
// f key
if (fullscreen.fulled) fullscreen.exit();
else fullscreen();
}

@tj
Copy link
Member

tj commented Sep 9, 2013

looks good to me except the name "fulled" is weird, maybe "enabled", so that in use it would look like if (fullscreen.enabled) {

@TooTallNate
Copy link
Member

+1 for enabled, or even just fullscreen or maybe even isFullscreen. Definitely not fulled since that's not a word.

@tj
Copy link
Member

tj commented Sep 9, 2013

fullscreen.isFullscreen would be a little redundant haha

@tj
Copy link
Member

tj commented Sep 9, 2013

didFullscreen hahah... jk

@shallker
Copy link
Author

I thought 'full' can be used as a verb, no? I'm too lazy to use the api if the name has more than 6 characters, or 5. fullscreen.isFullscreen doesn't sound nice. +1 for fullscreen.full or fullscreen.enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants