Drive initial search from URL query string

[JamesMGreene]

Fixes #82

[stephenmathieson]

is this if necessary?

• document.activeElement is always truthy
• search.el.contains(activeEl) should always be true as you're calling search.focus()

[JamesMGreene]

is this if necessary?

It's a stylistic thing IMHO. If the maintainers dislike it, I'm fine with changing it.

document.activeElement is always truthy

Usually but not always, e.g. document.activeElement can be null, at least in IE while the page is initially loading. You're right in that it should be a non-issue if search.focus() does its job, though.

search.el.contains(activeEl) should always be true as you're calling search.focus()

True based on the application-level view of things but that is dependent on the current function of the various components being pieced together. It may be over-cautious but it certainly isn't invalid.

shrugs

Like I said, I'm fine with changing whatever makes this get merged. 😛

[stephenmathieson]

why was build/build.js removed?

[JamesMGreene]

why was build/build.js removed?

It wasn't, GitHub just doesn't want to show the diff because there are too many changes.

https://github.com/JamesMGreene/component.github.io/blob/3bbde7855a99020ed89e501cace4b97650da9425/build/build.js

[stephenmathieson]

haha oops :p

[JamesMGreene]

The other approach I had in mind would eliminate all of this document.activeElement stuff and just add a new method to Search instead, e.g.

// In "boot/index.js":
var initialQuery = qs.parse(location.search).q || '';
search.input(initialQuery);
search.show(initialQuery);

// In "search/index.js":
SearchView.prototype.input = function(query) {
  this.el.querySelector('input').value = query;
};

[stephenmathieson]

+1 to SearchView#input

[JamesMGreene]

+1 to SearchView#input

OK, will do.

[JamesMGreene]

Amended.

Other new changes worth noting:

• Now always auto-focuses into the search box on load
• Initial URL query now calls search.search() instead of search.show(initialQuery) in order to maintain query analytics
  • SearchView#search had to be updated to fallback to getting the query value from the associated input element if it wasn't triggered by a DOM event

[JamesMGreene]

Initial URL query now calls search.search() instead of search.show(initialQuery) in order to maintain query analytics

That said, separate issue from this PR: the site's analytics object used within SearchView#search doesn't seem to exist:

[timaschew]

thanks. Have no time this week, but I will check it next week or maybe someone else :)

[JamesMGreene]

🤘