Constrain view to specified from/to years #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // allow for reversed range with from > to | ||
| var from = this._to < this._from ? this._to : this._from; | ||
| var to = this._to < this._from ? this._from : this._to; |
There was a problem hiding this comment.
i dont think we need reversing really, it would be pretty weird to specify them in reverse IMO
There was a problem hiding this comment.
I am using calendar in a colinf/datepicker. And for example when selecting date of birth, it is a common requirement especially when dealing with children to list years in reverse starting from current year.
BTW reversing can only be invoked if you accept my pull request (or an improved version of it!) to component/range.
Cheers, Colin
There was a problem hiding this comment.
ah I see what you mean, that makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue #15