Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using Percolator with more than 128 threads, MS2Rescore returns empty pout files #117

Closed
tivdnbos opened this issue Jan 4, 2024 · 0 comments · Fixed by #169
Closed
Milestone

Comments

@tivdnbos
Copy link
Contributor

tivdnbos commented Jan 4, 2024

Relevant output:

ms2rescore.rescoring_engines.percolator // Percolator output: Exception caught: -num-threads option requires an integer between 1 and 128 ERROR ms2rescore.main // Number of PSMs in original list (52729) does not match number of PSMs in Percolator output (0)

Therefore, if the number of threads in the config file is larger than 128 when using Percolator as rescoring engine, it should automatically be converted to a value lower than or equal to 128.

@RalfG RalfG linked a pull request Aug 7, 2024 that will close this issue
@RalfG RalfG added this to the v3.1.1 milestone Aug 7, 2024
@RalfG RalfG closed this as completed in 9676ddc Aug 14, 2024
RalfG added a commit that referenced this issue Aug 14, 2024
Limit Percolator processes to 128 (fixes #117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants