-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/better external data #887
Conversation
This needs to be tested on cordova before merging. Load development protocol from settings to do this. |
Already acknowledged with @jthrilly, csv isn't working for cordova (ios + android). |
In response to the poor performance of this, I made a stab at moving it to a web worker. The long term idea would be to move all blocking code to workers. It has definitely helped, but not as much as I had hoped. I think this means that the long, long term solution is to calculate this data once at a non performance critical moment (such as starting an interview session, or when the protocol is installed), and then store the decoded and restructured data. Then, stream it in as we do with media assets. |
I think it would be great to have this generate at interview start. Do we have any way of determining which bits are slow? If it's due to having large files/objects in memory then we may need to think of more alternative approaches, like a restful api, since we can't stream json. |
Resolves #885