Fix/Null column added to network #1272
Merged
+2
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On categorical bin interfaces without an other variable option, "null" was being added as a variable in the network.
This fix checks if resetVariable is truthy before adding it to the network. resetVariable exists in cases where a node is moved from a non-other bin to an other bin, or from an other bin to a non-other bin.
Same change from fix in Fresco complexdatacollective/Fresco#149